fix(Update reference from existingBucketInterface to existingBucketObj): Update Documentation
#520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conrad2134
requested review from
biffgaut,
hayesry and
hnishar
as code owners
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
biffgaut
changed the title
existingBucketInterface to existingBucketObjexistingBucketInterface to existingBucketObj): Update Documentation
biffgaut
approved these changes
Dec 1, 2021
There was a problem hiding this comment.
Thanks. Unfortunately this highlights a code problem, the property should be existingBucketInterface, as it accepts s3.IBucket instead of s3.Bucket. But we made a major push to change from Bucket to the more flexible IBucket months after dropping the original constructs and that would have been a breaking change, so we just have to live with it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: n/a
Description of changes: Tiny README change, updating a reference from the previous
existingBucketInterfaceto the newexistingBucketObj.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.