feat(cdk-v2): fixing assertion tests to work with both v1 and v2 #370
Conversation
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
| @@ -213,63 +213,6 @@ test('check the sns topic properties with existing KMS key', () => { | |||
| }); | |||
|
|
|||
| expect(stack).toHaveResource('AWS::KMS::Key', { | |||
| KeyPolicy: { | |||
There was a problem hiding this comment.
This seems to no longer check a good deal of stuff for correctness...why is this?
There was a problem hiding this comment.
OK (it's not letting me Resolve conversation
| @@ -115,64 +115,15 @@ test("test FunctionProps for no envrionment variable when runtime = PYTHON", () | |||
| expect(stack).toHaveResource( | |||
| "AWS::Lambda::Function", | |||
| { | |||
| Type: "AWS::Lambda::Function", | |||
There was a problem hiding this comment.
This no longer appears to confirm the stated purpose for the test (no environment variables). I'm concerned that our changes keep the tests passing, but the tests are no longer of value.
There was a problem hiding this comment.
The description of unit test is inaccurate, it's intent is to assert the runtime of lambda is python, will update the description
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
| @@ -213,63 +213,6 @@ test('check the sns topic properties with existing KMS key', () => { | |||
| }); | |||
|
|
|||
| expect(stack).toHaveResource('AWS::KMS::Key', { | |||
| KeyPolicy: { | |||
There was a problem hiding this comment.
OK (it's not letting me Resolve conversation
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue #, if available:
Description of changes:
Fixing assertion tests to work with both v1 and v2 by removing the assertions for KMS permissions (which have changed from v1 to v2) and lambda asset parameters (which are no longer required in v2)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.