feat(aws-eventbridge-sns) created new construct #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
2 tasks
biffgaut
requested changes
Aug 6, 2021
|
|
||
| Out of the box implementation of the Construct without any override will set the following defaults: | ||
|
|
||
| ### Amazon CloudWatch Events Rule |
| Out of the box implementation of the Construct without any override will set the following defaults: | ||
|
|
||
| ### Amazon CloudWatch Events Rule | ||
| * Grant least privilege permissions to CloudWatch Events to publish to the SNS Topic. |
There was a problem hiding this comment.
...permissions to EventBridge...
| public readonly encryptionKey?: kms.Key; | ||
|
|
||
| /** | ||
| * @summary Constructs a new instance of the EventRuleToSns class. |
There was a problem hiding this comment.
Change class name in summary
| @@ -86,8 +87,8 @@ _Parameters_ | |||
|
|
|||
| Out of the box implementation of the Construct without any override will set the following defaults: | |||
|
|
|||
| ### Amazon CloudWatch Events Rule | |||
| * Grant least privilege permissions to CloudWatch Events to publish to the SNS Topic. | |||
| ### Amazon EventBridge Rule | |||
There was a problem hiding this comment.
This is fine, not mandatory - it's in the README.md for the new name that we really must do this.
source/patterns/@aws-solutions-constructs/aws-events-rule-sns/test/integ.events-rule-no-arg.ts
Show resolved
Hide resolved
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
biffgaut
approved these changes
Aug 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #291 , if available:
Description of changes:
-Created new construct aws-eventbridge-sns
-Created wrapper in aws-events-rule-sns to support new construct
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.