Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[request]: Please add support for overriding profile file paths #237

Closed
bdonlan opened this issue Sep 29, 2021 · 5 comments
Closed

[request]: Please add support for overriding profile file paths #237

bdonlan opened this issue Sep 29, 2021 · 5 comments
Assignees
Labels
feature-request A feature should be added or improved.

Comments

@bdonlan
Copy link

bdonlan commented Sep 29, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue, please leave a comment

Tell us about your request
Please add an option to ProfileFileCredentialsProvider to load credentials from a nonstandard path.

Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?
Certain credential deployment systems work by placing credentials in a well-known path. Currently it is not possible to parse these credentials using the AWS SDK for rust, because it is not possible to override the profile path.

The rustdoc suggests aws_config::profile::load could be used to override this, but the rustdoc for this method does not provide a clear path to doing so (indeed, the Fs and Env arguments are not even rustdoc'd). When all you need is to load credentials, that's a lot more complexity than you'd need.

Are you currently working around this issue?
I am using rusoto to parse the profile and writing a custom ProvideCredentials to translate this to the Aws SDK credentials.

@bdonlan bdonlan added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Sep 29, 2021
@rcoh
Copy link
Contributor

rcoh commented Sep 30, 2021

I think this would be a reasonable feature. Did you see this section: https://awslabs.github.io/aws-sdk-rust/aws_config/profile/fn.load.html#location-of-profile-files?

The location of the config file will be loaded from the AWS_CONFIG_FILE environment variable with a fallback to ~/.aws/config
The location of the credentials file will be loaded from the AWS_SHARED_CREDENTIALS_FILE environment variable with a fallback to ~/.aws/credentials

But for some environments, I imagine that those variables aren't practical to set

@rcoh
Copy link
Contributor

rcoh commented Sep 30, 2021

Filed smithy-lang/smithy-rs#733 to track / prioritize fixing the docs.

@rcoh rcoh removed the needs-triage This issue or PR still needs to be triaged. label Sep 30, 2021
@bdonlan
Copy link
Author

bdonlan commented Oct 29, 2021

I did see that section, for my use case mutating global environment variables is not ideal.

@jdisanti
Copy link
Contributor

This feature was released in release-2022-10-26. The release notes have instructions on how to use it.

Repository owner moved this from Pending Release to Done in AWS Rust SDK Public Roadmap Oct 27, 2022
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved.
Projects
Archived in project
Development

No branches or pull requests

3 participants