-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conforming with PEP 518 to use pyproject.toml instead of requirements.txt/setuptools #1366
Comments
This is pertinent to #1369 as well, we are trying to get reproducible builds within sam cli when creating our installers. What has your experience been like with poetry? Does it also allow for generation of pinned dependencies. Reading about poetry, it seems to be pretty nice. @jfuss has also been looking into this recently. Might be another way to look at reproducible builds. For adding functionality to read pyproject.toml for |
@thesriram Thanks for the reply. Getting pinned requirements isn't bad. I have a python script that will read the
|
@tcco Poetry has a command to generate requirements.txt
|
Has any progress been made on this feature request? |
No progress on this front. This would be a change/addition to https://github.com/aws/aws-lambda-builders as that repo does all the heavy lifting. Our pip integration is pretty custom: https://github.com/aws/aws-lambda-builders/blob/develop/aws_lambda_builders/workflows/python_pip/DESIGN.md to allow us to build for Lambda. What likely needs to happen is a very similar workflow to the pip needs to be created but reads/uses the |
Bump to move this feature a little along as we also would like to use it soon (TM). Best wishes to our friends at aws! |
@jfuss, do you think it needs to be a separate workflow, or could the Do let me know if I've wandered off in the wrong direction. |
Maybe this is another solution: Support poetry on a level where it exports the dependencies without hashes into a temporary requirements.txt file. And then let your current code consume this file? My manual workflow currently is
Of course don't export it into the code directory but maybe into |
Describe your idea/feature/enhancement
Provide a clear description. Ex. I wish SAM CLI would [...]
I wish SAM CLI would utilize pyproject.toml for requirements. Subsequently, this would use additional package managers like poetry to in the
sam build
process.Proposal
Add details of how to add this to the product.
Add functionality to read pyproject.toml when running
sam build
Things to consider:
This would likely add another way to setup code architecture and application requirements in template.yaml files.
Additional Details
The text was updated successfully, but these errors were encountered: