fix: repository_name in image property of the codebuild provider #785
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
The repository_name in image property of the codebuild provider does not work as expected. By design, we can set the repository_name if the ECR is hosted in the deployment account in the main deployment region. However, when set image property to repository name, it does not work.
When set repository_name in image property of the codebuild provider in the deployment_map, I am getting following error:
My deployment map file looks like below:
What?
in
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_codebuild.py
, the methoddetermine_build_image
should change fromto