Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to use custom docker images for CodeBuild #196

Closed
eriklz opened this issue Nov 28, 2019 · 4 comments · Fixed by #208
Closed

Ability to use custom docker images for CodeBuild #196

eriklz opened this issue Nov 28, 2019 · 4 comments · Fixed by #208
Labels
enhancement New feature or request
Milestone

Comments

@eriklz
Copy link
Contributor

eriklz commented Nov 28, 2019

We have a requirement to run a couple of different custom docker images in some of our pipelines. This includes images fetched from ECR and images from DockerHub.

From what I could see in ADF 2.1.2 it does not support any images besides the predefined CodeBuild images currently. SO it would be great to be able to specify ECR images as well as DockerHub images, for at least build stage with CodeBuild.

@bundyfx
Copy link
Contributor

bundyfx commented Dec 17, 2019

Thanks @eriklz

Tested this out today in 3.0 beta and is working as intended and will make its way into the official 3.0 release shortly.

@amitsehgal
Copy link

@bundyfx looks like standard image provided by aws is also erroring out. Does above fix takes care of that ? tried using AMAZON_LINUX_2_2 https://docs.aws.amazon.com/cdk/api/latest/docs/@aws-cdk_aws-codebuild.LinuxBuildImage.html

  File "adf-build/cdk/generate_pipeline_stacks.py", line 37, in <module>
    main()
  File "adf-build/cdk/generate_pipeline_stacks.py", line 33, in main
    PipelineStack(app, stack_input)
  File "/codebuild/output/src189630871/src/adf-build/jsii/_runtime.py", line 66, in __call__
    inst = super().__call__(*args, **kwargs)
  File "/codebuild/output/src189630871/src/adf-build/cdk/cdk_stacks/main.py", line 69, in __init__
    {} # Empty target since this is a build only stage
  File "/codebuild/output/src189630871/src/adf-build/jsii/_runtime.py", line 66, in __call__
    inst = super().__call__(*args, **kwargs)
  File "/codebuild/output/src189630871/src/adf-build/cdk/cdk_constructs/adf_codebuild.py", line 83, in __init__
    build_image=getattr(_codebuild.LinuxBuildImage, map_params['default_providers']['build'].get('properties', {}).get('image', "UBUNTU_14_04_PYTHON_3_7_1")),
AttributeError: type object 'LinuxBuildImage' has no attribute 'AMAZON_LINUX_2_2'
Subprocess exited with error 1```

@bundyfx
Copy link
Contributor

bundyfx commented Jan 14, 2020

Hi @amitsehgal

Yes that is also resolved in 3.0 - thats because of the cdk version being used in 2.1.2 doesnt know about that image. we're bumped to 1.2.0 in 3.0.

@bundyfx bundyfx added the enhancement New feature or request label Jan 14, 2020
@bundyfx bundyfx mentioned this issue Jan 14, 2020
Merged
@sbkok sbkok added this to the v3.2.0 milestone Jan 24, 2023
@sbkok
Copy link
Collaborator

sbkok commented Jan 24, 2023

Thank you for your patience. I am happy to inform you that this feature has been released as part of v3.2.0 just now.
Please open a new issue if you are experiencing any issues related to this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants