Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow account exclusions in target group #145

Closed
thiezn opened this issue Aug 23, 2019 · 3 comments
Closed

Allow account exclusions in target group #145

thiezn opened this issue Aug 23, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@thiezn
Copy link
Contributor

thiezn commented Aug 23, 2019

Hi,

Would it be possible to add account exclusions to a target group? This could be handy during testing and specific account types that you don't want to create a whole new OU for.

Perhaps a syntax like the following would work:

pipelines:
  - name: mypipeline
    type: cc-cloudformation
    params:
      - SourceAccountId: 111111111111
    targets:
      - path: /development
        exclusions: [ 111222333444, 55566677788899 ]
        regions: eu-west-1

Cheers,
Thiezn

@bundyfx bundyfx added the enhancement New feature or request label Aug 24, 2019
@bundyfx
Copy link
Contributor

bundyfx commented Aug 24, 2019

Hi @thiezn

Thanks for the suggestion, it makes sense for certain situations and is pretty straight forward to implement. I'll tag this one for work after 1.3.0 as we're working hard to get the CDK integrated and pushed out. Of course in the meantime if you would like to add this in and submit a PR we can get it shipped in a patch version prior to 1.3.0.

Cheers
Flynn

@thiezn
Copy link
Contributor Author

thiezn commented Aug 26, 2019

Thanks @bundyfx

I'll take a look and see if I can get something working in a few days.

Cheers,
Thiezn

@sbkok
Copy link
Collaborator

sbkok commented Jan 24, 2023

Thank you for your patience. I am happy to inform you that this feature has been released as part of v3.2.0 just now.
I'm hereby closing this issue. Please open a new issue if you are experiencing any issues related to this feature.

@sbkok sbkok closed this as completed Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants