Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-cdk-java: Normalize maven usage #148

Merged
merged 16 commits into from
Jun 21, 2018
Merged

aws-cdk-java: Normalize maven usage #148

merged 16 commits into from
Jun 21, 2018

Conversation

eladb
Copy link
Contributor

@eladb eladb commented Jun 20, 2018

  • Use a generated pom.xml to plug-in version numbers
  • Emit a local maven repo directory structure to maven-repo

By submitting this pull request, I confirm that my contribution is made under
the terms of the beta license.

Elad Ben-Israel added 3 commits June 20, 2018 15:35
Passing through JSON requests through shell scripts can easily
cause escaping hell, since double-quotes are parsed by the shell
and omitted. Once those requests need to hop through two shell
scripts, it is practically impossible to escape them probably, and
the last thing we want.

To completely eliminate the need to escape, cx-api
now supports accepting requests with base64 encoding. Those are
prefixed by the string "base64:", decoded and then parsed as JSON.

To decode base64, a bundled dependency on js-base64 was added.

Misc: if an errors occurs, toolkit emits contents of STDOUT to allow
diagnostics.
* Use a generated pom.xml to plug-in version numbers
* Emit a local maven repo directory structure to `maven-repo`
@eladb eladb requested a review from RomainMuller June 20, 2018 12:54
@eladb eladb changed the base branch from benisrae/cxapi-beta64 to master June 20, 2018 13:23
@eladb eladb merged commit 8c81c7d into master Jun 21, 2018
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants