-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version reporting is not working for env-agnostic stacks #3142
Version reporting is not working for env-agnostic stacks #3142
Comments
Wow, @jogold thanks for reporting this. Nice catch! |
Just found out because I have one of my cdk stacks that is creating only one resource via Previously this stack deployed fine because the template contained a May I open a PR to skip deploying stacks without resources? via filter in |
Why not? Sounds good. Issue a warning? |
Fixes a bug that caused the CDK Metadata resource to not be emitted if a stack was not bound to a particular supported region. The fixed behavior will generate the resource for supported regions as well as for region independent stacks. Fixes #3142
I'm submitting a ...
What is the current behavior?
When working/deploying env-agnostic stacks version reporting is not working (
AWS::CDK::Metadata
is never deployed). This is because the check for the factCDK_METADATA_RESOURCE_AVAILABLE
fails (region is unknown).What is the expected behavior (or behavior of feature suggested)?
Version reporting should work for env-agnostic stacks. The version reporting check should use the deploy time resolved region.
Please tell us about your environment:
The text was updated successfully, but these errors were encountered: