-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(codepipeline): generate a Role for every AWS-owned Action used in a Pipeline #3105
Merged
skinny85
merged 1 commit into
aws:master
from
skinny85:feature/role-per-pipeline-action
Jun 28, 2019
Merged
feat(codepipeline): generate a Role for every AWS-owned Action used in a Pipeline #3105
skinny85
merged 1 commit into
aws:master
from
skinny85:feature/role-per-pipeline-action
Jun 28, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rix0rrr
approved these changes
Jun 28, 2019
skinny85
force-pushed
the
feature/role-per-pipeline-action
branch
from
June 28, 2019 16:35
f5388eb
to
e4a89f4
Compare
Rebased to make 100% sure the build passes (there are a lot of integ test changes here). |
5 tasks
This was referenced Aug 22, 2019
This was referenced Dec 12, 2019
This was referenced Sep 24, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of granting permissions to the Pipeline's Role,
which results in a Policy with a very wide range of permissions,
generate a separate Role for each AWS-owned Action added to the Pipeline.
The Pipeline Role will assume each Action-specific Role
(permissions are granted for that automatically)
before the Action is executed.
Also allow customers to override that default behavior by specifying their own Role for AWS-owned Actions.
While testing this change, I realized most of our Actions were generating an incomplete set of permissions to the Pipeline's artifact Bucket
(which was missed because the Actions previously executed in the context of the Pipeline Role,
which naturally has read-write permissions to that Bucket).
Corrected that as well.
Please read the contribution guidelines and follow the pull-request checklist.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license