-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: update all enum members to be ALL_CAPS - part II #2989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated enum members in core modules, drift from recent merges, and packages that were missed in the first pass. This is in accordance with the new construct library guidelines. **Fixes #2287** BREAKING CHANGE: all enum members were changed from `PascalCase` to `ALL_CAPS`
shivlaks
requested review from
RomainMuller,
skinny85 and
SoManyHs
as code owners
June 21, 2019 10:47
How is that possible? Did we not have a linter rule to prevent new incoming drift? |
rix0rrr
approved these changes
Jun 21, 2019
It's being enforced at the jsii level - so it's from testing locally against the latest in jsii :) |
1 task
This was referenced Aug 22, 2019
This was referenced Dec 12, 2019
This was referenced Dec 13, 2019
This was referenced Jan 20, 2020
This was referenced Sep 24, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated enum members in core modules, drift from recent merges, and packages
that were missed in the first pass.
This is in accordance with the new construct library guidelines.
Fixes #2287
BREAKING CHANGE: all enum members were changed from
PascalCase
toALL_CAPS
Pull Request Checklist
design
folderBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.