Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rds): DatabaseCluster exposes read endpoint #2970

Merged
merged 1 commit into from
Jun 21, 2019

Conversation

rpanfili
Copy link
Contributor

@rpanfili rpanfili commented Jun 20, 2019

Fix a typo that exposes cluster write endpoint as clusterReadEndpoint
on RDS DatabaseCluster

fixes #2969


Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
    • Design: For significant features, design document added to design folder
  • Title and Description
    • Change type: title prefixed with fix, feat and module name in parens, which will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@rpanfili rpanfili requested a review from a team as a code owner June 20, 2019 17:44
@rpanfili
Copy link
Contributor Author

Let me know if you think we need a Unit for this (kind of) issue!

@rix0rrr
Copy link
Contributor

rix0rrr commented Jun 21, 2019

A test would be great, yes!

Fix a typo that exposes cluster write endpoint as `clusterReadEndpoint`
on RDS DatabaseCluster

fixes aws#2969
@rpanfili
Copy link
Contributor Author

ok, added a Unit and CI is running. Not sure is a good test (checks the resolved value of these properties are different). Let me know if there is a better way to check against this issue :)

@rix0rrr
Copy link
Contributor

rix0rrr commented Jun 21, 2019

Haha, I like it! Thanks.

@rix0rrr rix0rrr merged commit 2d50c18 into aws:master Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RDS Cluster does not expose read endpoint correctly
2 participants