Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(aws-stepfunctions, aws-stepfunctions-tasks): missing suffix ".$" in field names of reference paths #2937

Closed
wqzoww opened this issue Jun 19, 2019 · 0 comments · Fixed by #2939 or MechanicalRock/tech-radar#14 · May be fixed by MechanicalRock/cdk-constructs#5, MechanicalRock/cdk-constructs#6 or MechanicalRock/cdk-constructs#7
Closed

fix(aws-stepfunctions, aws-stepfunctions-tasks): missing suffix ".$" in field names of reference paths #2937

wqzoww opened this issue Jun 19, 2019 · 0 comments · Fixed by #2939 or MechanicalRock/tech-radar#14 · May be fixed by MechanicalRock/cdk-constructs#5, MechanicalRock/cdk-constructs#6 or MechanicalRock/cdk-constructs#7
Labels
bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.

Comments

@wqzoww
Copy link
Contributor

wqzoww commented Jun 19, 2019

Describe the bug
The suffix ".$" is missing in the field "token" whose value is a reference path "$$.Task.Token" in the following unit test:
https://github.com/awslabs/aws-cdk/blob/ea10f0d141a48819ec0000cd7905feda993870a9/packages/%40aws-cdk/aws-stepfunctions-tasks/test/invoke-function.test.ts#L78
Users can create their state machine with such definition but runtime exception will be thrown because of the missing suffix when they start any execution.

Expected behavior
All the fields with reference paths in the state machine definition should end with ".$".
The payload field should look like:

"Payload": {
    "token.$": "$$.Task.Token"
}

Reference
https://states-language.net/spec.html

Version:
@wqzoww wqzoww added the bug This issue is a bug. label Jun 19, 2019
@wqzoww wqzoww changed the title fix(aws-stepfunctions, aws-stepfunctions-tasks): Missing suffix ".$" in field names of reference paths fix(aws-stepfunctions, aws-stepfunctions-tasks): missing suffix ".$" in field names of reference paths Jun 19, 2019
wqzoww added a commit to wqzoww/aws-cdk that referenced this issue Jun 19, 2019
@wqzoww
fix(aws-stepfunctions, aws-stepfunctions-tasks): missing suffix in fi…
2e74335 
…eld names of reference paths

* add suffix ".$" for the fields whose values are reference paths, including json path and context object
* fix unit tests and integration test for lambda task

issue: aws#2937
wqzoww added a commit to wqzoww/aws-cdk that referenced this issue Jun 19, 2019
@wqzoww
fix(aws-stepfunctions, aws-stepfunctions-tasks): missing suffix in fi…
a75dc02 
…eld names of reference paths

* add suffix ".$" for the fields whose values are reference paths, including json path and context object
* fix unit tests and integration test for lambda task

fixes aws#2937
@wqzoww wqzoww mentioned this issue Jun 19, 2019
Merged
4 tasks
@NGL321 NGL321 added the needs-triage This issue or PR still needs to be triaged. label Jun 20, 2019
rix0rrr pushed a commit that referenced this issue Jun 21, 2019
@wqzoww @rix0rrr
fix(stepfunctions): fix passing of Token in RunLambdaTask (#2939)
58a80ab 
Fixes #2937.
This was referenced Aug 22, 2019
Open
Open
Open
Open
Open
@aereal aereal mentioned this issue Sep 14, 2019
Closed
This was referenced Dec 12, 2019
Closed
Closed
Closed
Merged
Closed
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Jan 20, 2020
Closed
Closed
@NOUIY NOUIY mentioned this issue Sep 24, 2024
Open
This was referenced Sep 24, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
@NOUIY NOUIY mentioned this issue Oct 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(aws-stepfunctions, aws-stepfunctions-tasks): missing suffix in fi… wqzoww/aws-cdk
[Snyk] Upgrade @aws-cdk/aws-iam from 0.22.0 to 0.39.0 MechanicalRock/tech-radar
[Snyk] Upgrade @aws-cdk/aws-codebuild from 0.24.1 to 0.39.0 MechanicalRock/cdk-constructs
[Snyk] Upgrade @aws-cdk/aws-codepipeline from 0.24.1 to 0.39.0 MechanicalRock/cdk-constructs
[Snyk] Upgrade @aws-cdk/aws-s3 from 0.24.1 to 0.39.0 MechanicalRock/cdk-constructs
[Snyk] Upgrade @aws-cdk/aws-cloudfront from 0.15.2 to 0.39.0 MechanicalRock/cdk-products
[Snyk] Upgrade @aws-cdk/aws-codebuild from 0.15.2 to 0.39.0 MechanicalRock/cdk-products
[Snyk] Upgrade @aws-cdk/aws-codecommit from 0.15.2 to 0.39.0 MechanicalRock/cdk-products
[Snyk] Upgrade @aws-cdk/aws-codepipeline from 0.15.2 to 0.39.0 MechanicalRock/cdk-products
[Snyk] Upgrade @aws-cdk/aws-cloudformation from 0.0.0 to 0.39.0 NOUIY/aws-solutions-constructs
2 participants
@NGL321 @wqzoww