-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(aws-stepfunctions): add support for AmazonSageMaker APIs #2808
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, lots of work! Thanks!
Probably made a lot harder by the fact that we don't have SageMaker L2s yet (which also makes some points of the review moot).
Given that I have no experience with SageMaker, nor the time to learn about it right now, I'm inclined to just ship this as-is and let usage and review comments sort out how well it's working.
Can you please mark all new interfaces and classes with an
/**
* @experimental
*/
In the docstrings?
packages/@aws-cdk/aws-stepfunctions-tasks/lib/sagemaker-train-task.ts
Outdated
Show resolved
Hide resolved
Have marked all new interfaces and classes with |
Have updated the package `@aws-cdk/aws-stepfunctions-tasks` to include support for SageMaker APIs as per documentation here: https://docs.aws.amazon.com/step-functions/latest/dg/connect-sagemaker.html Includes support for the following Amazon SageMaker API calls: * `CreateTrainingJob` * `CreateTransformJob` Partially remediates aws#1314
Have updated the package
@aws-cdk/aws-stepfunctions-tasks
to include support for SageMaker APIs as per documentation here: https://docs.aws.amazon.com/step-functions/latest/dg/connect-sagemaker.htmlIncludes support for the following Amazon SageMaker API calls:
CreateTrainingJob
CreateTransformJob
Partially remediates #1314
Pull Request Checklist
design
folderBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.