Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(toolkit): allow to pass build args to docker build #2604

Merged
merged 1 commit into from
May 22, 2019

Conversation

jogold
Copy link
Contributor

@jogold jogold commented May 21, 2019

Closes #1271


Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
    • Design: For significant features, design document added to design folder
  • Title and Description
    • Change type: title prefixed with fix, feat and module name in parens, which will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@jogold jogold requested review from SoManyHs and a team as code owners May 21, 2019 15:11
@eladb
Copy link
Contributor

eladb commented May 21, 2019

We may also want to expose this in ECS’s container image APIs

@jogold
Copy link
Contributor Author

jogold commented May 21, 2019

We may also want to expose this in ECS’s container image APIs

It's available in ecs.ContainerImage.fromAsset which returns an AssetImage which creates a DockerImageAsset.

Is this what you meant?

@rix0rrr rix0rrr merged commit c51596e into aws:master May 22, 2019
@jogold jogold deleted the docker-build-args branch June 13, 2019 13:19
This was referenced Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle Build Args in ContainerImage.fromAsset()
3 participants