fix(ecs): correct logic of healthcheck command #2462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a healthcheck command to an ECS container definition
results in an invalid command after synthesizing.
Before:
Input: ['CMD', 'command']
Output:
HealthCheck:
Command:
- CMD
- CMD
- echo
- z
Input: ['CMD-SHELL', 'command']
Output:
HealthCheck:
Command:
- CMD
- CMD-SHELL
- echo
- z
After:
Input: ['CMD', 'command']
Output:
HealthCheck:
Command:
- CMD
- echo
- z
Input: ['CMD-SHELL', 'command']
Output:
HealthCheck:
Command:
- CMD-SHELL
- echo
- z
fixes #2461
Signed-off-by: Chris Lahaye <dev@chrislahaye.com>
SoManyHs
approved these changes
May 2, 2019
piradeepk
reviewed
May 2, 2019
| @@ -478,7 +478,7 @@ function getHealthCheckCommand(hc: HealthCheck): string[] { | |||
| return hcCommand; | |||
| } | |||
|
|
|||
| if (cmd[0] !== "CMD" || cmd[0] !== 'CMD-SHELL') { | |||
| if (cmd[0] !== "CMD" && cmd[0] !== 'CMD-SHELL') { | |||
There was a problem hiding this comment.
Can you add a unit test to ensure that this check is working as expected?
There was a problem hiding this comment.
@pkandasamy91 the existing test should be sufficient.
There was a problem hiding this comment.
Will add missing tests in a separate PR.
piradeepk
approved these changes
May 3, 2019
SanderKnape
pushed a commit
to SanderKnape/aws-cdk
that referenced
this pull request
May 14, 2019
Adding a healthcheck command to an ECS container definition
results in an invalid command after synthesizing.
Before:
Input: ['CMD', 'command']
Output:
HealthCheck:
Command:
- CMD
- CMD
- echo
- z
Input: ['CMD-SHELL', 'command']
Output:
HealthCheck:
Command:
- CMD
- CMD-SHELL
- echo
- z
After:
Input: ['CMD', 'command']
Output:
HealthCheck:
Command:
- CMD
- echo
- z
Input: ['CMD-SHELL', 'command']
Output:
HealthCheck:
Command:
- CMD-SHELL
- echo
- z
fixes aws#2461
Signed-off-by: Chris Lahaye <dev@chrislahaye.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a healthcheck command to an ECS container definition
results in an invalid command after synthesizing.
Before:
After:
fixes #2461
Signed-off-by: Chris Lahaye dev@chrislahaye.com
Pull Request Checklist
designfolderBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.