Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TargetGroup construct does not set target group's name correctly #1674

Closed
motemen opened this issue Feb 5, 2019 · 0 comments · Fixed by #1684
Closed

TargetGroup construct does not set target group's name correctly #1674

motemen opened this issue Feb 5, 2019 · 0 comments · Fixed by #1684
Labels
@aws-cdk/aws-elasticloadbalancing Related to Amazon Elastic Load Balancing bug This issue is a bug.

Comments

@motemen
Copy link
Contributor

motemen commented Feb 5, 2019

TargetGroup construct accept targetGroupName as its prop and passes it to underlying CfnTargetGroup by the same name targetGroupName.

https://github.com/awslabs/aws-cdk/blob/299fb6a71ae94950c8d3c844d14779feb68e215f/packages/%40aws-cdk/aws-elasticloadbalancingv2/lib/shared/base-target-group.ts#L216

But the correct prop name is Name, not TargetGroupName, so we cannot set the resource's name using the construct.
@eladb eladb added bug This issue is a bug. @aws-cdk/aws-elasticloadbalancing Related to Amazon Elastic Load Balancing labels Feb 5, 2019
motemen added a commit to motemen/aws-cdk that referenced this issue Feb 6, 2019
@motemen
fix(elbv2): use correct prop for TargetGroup name
26fc74c 
TargetGroup construct passes targetGroupName prop to underlying
CfnTargetGroup, but the correct name is Name, not TargetGroupName.

fixes aws#1674
@motemen motemen mentioned this issue Feb 6, 2019
Merged
4 tasks
rix0rrr pushed a commit that referenced this issue Feb 6, 2019
@motemen @rix0rrr
fix(elbv2): fix specifying TargetGroup name (#1684)
1d7198a 
TargetGroup construct passes targetGroupName prop to underlying
CfnTargetGroup, but the correct name is Name, not TargetGroupName.

Fixes #1674
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-elasticloadbalancing Related to Amazon Elastic Load Balancing bug This issue is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(elbv2): use correct prop for TargetGroup name motemen/aws-cdk
2 participants
@motemen @eladb