Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ecs): support container environment variables #1537

Merged
merged 1 commit into from
Jan 14, 2019

Conversation

PaulMaddox
Copy link
Contributor

Example usage:

// Create a nginx service, with an environment variable
new ecs.LoadBalancedFargateService(this, 'NginxService', {
  cluster: cluster,
  image: ecs.ContainerImage.fromDockerHub('nginx:latest'),
  environment: {
    TEST_ENVIRONMENT_VARIABLE: "test-value"
  }
})

I had originally planned to add the ability to add secrets too, however this doesn't seem to be supported by CloudFormation yet.

Fixes #1296


Pull Request Checklist

  • Testing
    • Unit test added
    • CLI change?: manually run integration tests and paste output as a PR comment
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
  • Title and Description
    • Change type: title prefixed with fix, feat will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@PaulMaddox PaulMaddox requested review from SoManyHs and a team as code owners January 14, 2019 07:16
@rix0rrr rix0rrr merged commit b633505 into aws:master Jan 14, 2019
@PaulMaddox PaulMaddox deleted the ecs-environment-variables branch January 14, 2019 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LoadBalancedFargateService does not expose environment variables
2 participants