Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toolkit: cdk destroy needs to reverse stacks w/ dependencies based on topological ordering #1508

Closed
rix0rrr opened this issue Jan 10, 2019 · 0 comments · Fixed by #1511
Closed

Toolkit: cdk destroy needs to reverse stacks w/ dependencies based on topological ordering #1508

rix0rrr opened this issue Jan 10, 2019 · 0 comments · Fixed by #1511
Assignees
@rix0rrr
Labels
bug This issue is a bug. package/tools Related to AWS CDK Tools or CLI

Comments

@rix0rrr
Copy link
Contributor

rix0rrr commented Jan 10, 2019 •
edited
Loading

See title.

Change the integ test that does ls today to do an actual deploy + destroy.
@rix0rrr rix0rrr added bug This issue is a bug. package/tools Related to AWS CDK Tools or CLI labels Jan 10, 2019
@rix0rrr rix0rrr self-assigned this Jan 10, 2019
rix0rrr added a commit that referenced this issue Jan 10, 2019
@rix0rrr
fix(aws-cdk): destroy stacks in reverse order
2a3752c 
Fixes #1508.
@rix0rrr rix0rrr mentioned this issue Jan 10, 2019
Merged
4 tasks
rix0rrr added a commit that referenced this issue Jan 10, 2019
@rix0rrr
feat(aws-cdk): better stack dependency handling (#1511)
b4bbaf0 
Two improvements to stack dependency handling in the toolkit:

* Destroy stacks in reverse order. This is necessary to properly dispose of stacks that
  use exports and `Fn::ImportValue`. Fixes #1508.
* Automatically include stacks that have a dependency relationship
  with the requested stacks, unless `--exclusively` (`-e`) is
  passed on the command line. Fixes #1505.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rix0rrr rix0rrr

Labels
bug This issue is a bug. package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(aws-cdk): better stack dependency handling aws/aws-cdk
1 participant
@rix0rrr