scrutiny: cdk no-ops (successfully) with no tty #1380
Assignees
Labels
bug
This issue is a bug.
Comments
eladb
pushed a commit
that referenced
this issue
Dec 17, 2018
If STDIN is not connected to a TTY (terminal), and scrutiny is enabled, we expect the program to fail (exit with non-zero exit code). This is especially important for CI/CD scenarios where you wouldn't want to accidentally deploy changes that didn't pass a scrutiny check. Fixes #1380 Tested manually.
9 tasks
eladb
pushed a commit
that referenced
this issue
Dec 19, 2018
If STDIN is not connected to a TTY (terminal), and scrutiny is enabled, we expect the program to fail (exit with non-zero exit code). This is especially important for CI/CD scenarios where you wouldn't want to accidentally deploy changes that didn't pass a scrutiny check. Added integration test. Fixes #1380
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When running
cdk deploythe--require-approvalenabled in an environment without tty, such as CI/CD or integration tests (terminal is not attached), the toolkit will not deploy and exit with exit status 0. We expect it to fail in this caseThe text was updated successfully, but these errors were encountered: