Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-logs): set default log retention of LogGroup to 731 instead of 730 (#1343) #1344

Merged
merged 1 commit into from
Dec 13, 2018

Conversation

sam-goodwin
Copy link
Contributor

Fixes #1343

Pull Request Checklist

Please check all boxes, including N/A items:

Testing

  • Unit test and/or integration test added
  • Toolkit change?: integration tests manually executed (paste output to the PR description)
  • Init template change?: coordinated update of integration tests (currently maintained in a private repo).

Documentation

  • README: README and/or documentation topic updated
  • jsdocs: All public APIs documented

Title and description

  • Change type: Title is prefixed with change type:
    • fix(module): <title> bug fix (patch)
    • feat(module): <title> feature/capability (minor)
    • chore(module): <title> won't appear in changelog
    • build(module): <title> won't appear in changelog
  • Title format: Title uses lower case and doesn't end with a period
  • Breaking change?: Last paragraph of description is: BREAKING CHANGE: <describe exactly what changed and how to achieve similar behavior + link to documentation/gist/issue if more details are required>
  • References: Indicate issues fixed via: Fixes #xxx or Closes #xxx

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@sam-goodwin sam-goodwin added bug This issue is a bug. @aws-cdk/aws-cloudwatch Related to Amazon CloudWatch labels Dec 12, 2018
@sam-goodwin sam-goodwin requested a review from a team as a code owner December 12, 2018 23:28
@eladb
Copy link
Contributor

eladb commented Dec 13, 2018

Fixes #1343

@eladb eladb merged commit 71dc09f into master Dec 13, 2018
@eladb eladb deleted the samgood/logretentionfix branch December 13, 2018 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-cloudwatch Related to Amazon CloudWatch bug This issue is a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default retentionDays value '730' for LogGroup is invalid
2 participants