fix(aws-ec2): add dependency on gateway attachment for public routes #1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eladb
approved these changes
Nov 11, 2018
There was a problem hiding this comment.
Looks good. A couple of notes on PR description:
- Use lower-case letters for the title
- Describe the motivation for the change (why is the explicit dependency needed)
- The "BREAKING CHANGE" section should be more detailed, so that someone how reads it will know exactly what broke and how they are supposed to continue to use this API.
clareliguori
changed the title
|
Please switch the order of paragraphs in the commit description so that the BREAKING CHANGE paragraph is last (as per conventionalcommits. The reason we are particular about this is because we generate our changelogs from these, and if there’s a breaking change, everything below it will be taken. |
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1140. Currently there is a race condition when creating the public subnet routes for the ec2.VpcNetwork construct. CloudFormation can attempt to create the public subnet routes to the IGW before the IGW is attached to the VPC. This change adds a dependency to the public routes on the IGW attachment,
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.
BREAKING CHANGE: Method signature of VpcPublicSubnet.addDefaultIGWRouteEntry changed in order to add a dependency on gateway attachment completing before creating the public route to the gateway. Instead of passing a gateway ID string, pass in a cloudformation.InternetGatewayResource object and a cloudformation.VPCGatewayAttachmentResource object.