Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cdk diff: doesn't doesn't indicate "parameters" and "outputs" #1120

Closed
eladb opened this issue Nov 8, 2018 · 0 comments · Fixed by #1187
Closed

cdk diff: doesn't doesn't indicate "parameters" and "outputs" #1120

eladb opened this issue Nov 8, 2018 · 0 comments · Fixed by #1187
Labels
feature-request A feature should be added or improved. package/tools Related to AWS CDK Tools or CLI ui Related to CLI User Interface issues

Comments

@eladb
Copy link
Contributor

eladb commented Nov 8, 2018

There is no indication that an entity added/removed/changed is a Parameter or an Output:

For example, HelloFunctionCodeS3Bucket0C5C164D is a new parameter:

[+] Added HelloFunctionCodeS3Bucket0C5C164D: {"Type":"String","Description":"S3 bucket for asset \"CdkDemoStack/HelloFunction/Code\""}
[+] Added HelloFunctionCodeS3VersionKeyAC59E192: {"Type":"String","Description":"S3 key for asset version \"CdkDemoStack/HelloFunction/Code\""}
[+]  Creating HelloFunctionServiceRole186F1BA8 (type: AWS::IAM::Role)
[+]  Creating HelloFunctionD909AE8C (type: AWS::Lambda::Function)
@rix0rrr rix0rrr added enhancement package/tools Related to AWS CDK Tools or CLI labels Nov 11, 2018
@eladb eladb added the ui Related to CLI User Interface issues label Nov 13, 2018
eladb pushed a commit that referenced this issue Nov 15, 2018
feat(toolkit): improve diff user interface
7f33973 
- When possible, display element's construct path alongside 
  logical ID (fixes #1121)
- Sort changes according to type: removed > added > updated > other
- Add section headers: parameters, resources, 
  output (fixes #1120)
- Reduce clutter and emojis
 
To display construct path we fuse metadata from the synthesized output
(CDK metadata) and info from the the "aws:cdk:path" CloudFormation
metadata (if exists).
@eladb eladb mentioned this issue Nov 15, 2018
Merged
3 tasks
eladb pushed a commit that referenced this issue Nov 18, 2018
feat(toolkit): improve diff user interface (#1187)
9c3c5c7 
- When possible, display element's construct path alongside 
  logical ID (fixes #1121)
- Sort changes according to type: removed > added > updated > other
- Add section headers: parameters, resources, 
  output (fixes #1120)
- Reduce clutter and emojis
 
To display construct path we fuse metadata from the synthesized output
(CDK metadata) and info from the the "aws:cdk:path" CloudFormation
metadata (if exists).
@srchase srchase added feature-request A feature should be added or improved. and removed enhancement labels Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request A feature should be added or improved. package/tools Related to AWS CDK Tools or CLI ui Related to CLI User Interface issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(toolkit): improve diff user interface aws/aws-cdk
3 participants
@rix0rrr @eladb @srchase