chore: update Hibernate sample code #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <property name="hibernate.connection.driver_class" value="software.amazon.jdbc.Driver"/> | ||
| <property name="hibernate.connection.url" value="jdbc:aws-wrapper:postgresql://hostname.amazonaws.com/hibernate_orm_test"/> | ||
| <property name="hibernate.connection.url" value="jdbc:aws-wrapper:postgresql://database-pg.cluster-cwpu2jclcwdc.us-east-2.rds.amazonaws.com/hibernate_orm_test"/> |
There was a problem hiding this comment.
don't forget to remove this :P
karenc-bq
force-pushed
the
update_hibernate_example
branch
from
eba3bc0 to
015c86d
Compare
sergiyvamz
reviewed
Mar 16, 2023
| public static void main(String[] args) { | ||
| int i = 0; | ||
| try { | ||
| while (true) { |
There was a problem hiding this comment.
Need a condition to exit the loop. It could be a time (5 min?) or a number of iteration.
karenc-bq
force-pushed
the
update_hibernate_example
branch
from
5f31ce4 to
d02e797
Compare
aaronchung-bitquill
approved these changes
Mar 17, 2023
sergiyvamz
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update Hibernate sample code to reflect changes in the wrapper source code.
Description
Additional Reviewers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.