Skip to content

Commit cdce4a5

Browse files
Shu Shenshushen
authored andcommitted
wip: improve test setup error handling
1 parent 5590c85 commit cdce4a5

File tree

2 files changed

+10
-5
lines changed

2 files changed

+10
-5
lines changed

tests/integration/integration_test_base.py

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,14 +32,19 @@ def __init__(self, ledger_name, region):
3232
def force_delete_ledger(self):
3333
try:
3434
logger.info("Deleting ledger %s", self.ledger_name)
35-
self.qldb.update_ledger(Name=self.ledger_name, DeletionProtection=False)
3635
self.delete_ledger()
37-
except ClientError as ce:
38-
logger.warning("Encountered an error while force deleting ledger %s: %s", self.ledger_name, ce)
36+
except (self.qldb.exceptions.ResourceInUseException, self.qldb.exceptions.ResourcePreconditionNotMetException) as e:
37+
logger.warning(e)
38+
# Test deleting state
39+
self.wait_for_active()
40+
self.delete_ledger()
3941

4042
def delete_ledger(self):
4143
logger.info("Deleting ledger %s", self.ledger_name)
42-
self.qldb.update_ledger(Name=self.ledger_name, DeletionProtection=False)
44+
try:
45+
self.qldb.update_ledger(Name=self.ledger_name, DeletionProtection=False)
46+
except self.qldb.exceptions.ResourceNotFoundException:
47+
return
4348
self.qldb.delete_ledger(Name=self.ledger_name)
4449
self.wait_for_deletion()
4550

tests/integration/test_session_management.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ def setUpClass(cls):
3030

3131
@classmethod
3232
def tearDownClass(cls):
33-
cls.integration_test_base.delete_ledger()
33+
cls.integration_test_base.force_delete_ledger()
3434

3535
def test_connect_to_non_existent_ledger(self):
3636
with self.integration_test_base.qldb_driver("nonExistentLedger") as qldb_driver:

0 commit comments

Comments
 (0)