Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Check for copyright in Python scripts #2298

Closed
dougch opened this issue Sep 17, 2020 · 1 comment
Closed

ci: Check for copyright in Python scripts #2298

dougch opened this issue Sep 17, 2020 · 1 comment
Labels

Comments

@dougch
Copy link
Contributor

dougch commented Sep 17, 2020

Security issue notifications

If you discover a potential security issue in s2n we ask that you notify
AWS Security via our vulnerability reporting page. Please do not create a public github issue.

Problem:

The copyright_mistake_scanner.sh doesn't look at python scripts

Solution:

Update the S2N_FILES variable to look at *.py

  • Does this change what S2N sends over the wire? no
  • Does this change any public APIs? no
  • Which versions of TLS will this impact? n/a

Requirements / Acceptance Criteria:

This will likely require a large PR to address.

Out of scope:

Is there anything the solution will intentionally NOT address?

@jmayclin
Copy link
Contributor

Fixed in #4732

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants