From f347fa52138d0d47ebc1ce6cf22271bc1b4be72a Mon Sep 17 00:00:00 2001 From: DougCh Date: Fri, 20 Dec 2024 19:30:26 +0000 Subject: [PATCH] Fix msrv-url; more PR feedback --- .github/workflows/ci_rust.yml | 2 +- bindings/README.md | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci_rust.yml b/.github/workflows/ci_rust.yml index 11cf0df5522..b8a0acb362c 100644 --- a/.github/workflows/ci_rust.yml +++ b/.github/workflows/ci_rust.yml @@ -91,7 +91,7 @@ jobs: cd ${{env.ROOT_PATH}} ./generate.sh - ldd standard/target/debug/integration | grep libs2n.so + ldd ${{env.STANDARD_PATH}}/target/debug/integration | grep libs2n.so # our benchmark testing includes interop tests between s2n-tls, rustls, and # openssl diff --git a/bindings/README.md b/bindings/README.md index b1f45dae70c..a74d880cd76 100644 --- a/bindings/README.md +++ b/bindings/README.md @@ -29,17 +29,17 @@ There are two rust bindings workspaces that have different MSRV policies. Crates ### Extended -The current MSRV for `s2n-tls`, `s2n-tls-sys` and `s2n-tls-tokio` is [1.63.0][msrv-url]. +The current MSRV for `s2n-tls`, `s2n-tls-sys` and `s2n-tls-tokio` is [1.63.0](https://releases.rs/docs/1.63.0/). ### Standard We will maintain a rolling MSRV (minimum supported rust version) policy of at least 6 months. The current s2n-quic version is not guaranteed to build on Rust versions earlier than the MSRV. -The current MSRV for the standard workspace is [1.74.0][msrv-url]. +The current MSRV for the standard workspace is [1.74.0](https://releases.rs/docs/1.74.0/) ### Rust Examples -The current MSRV for the Rust Examples workspace is [stable][msrv-url]. +The current MSRV for the Rust Examples workspace is [stable](https://releases.rs/).