Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update pod level controls for TGP #7710

Merged
merged 3 commits into from
Feb 10, 2025

Conversation

jmdeal
Copy link
Contributor

@jmdeal jmdeal commented Feb 7, 2025

Fixes #7708

Description
Updates the disruption docs to reflect the interaction between TGP and the do-not-disrupt annotation.

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmdeal jmdeal requested a review from a team as a code owner February 7, 2025 18:49
@jmdeal jmdeal requested a review from edibble21 February 7, 2025 18:49
Copy link

netlify bot commented Feb 7, 2025

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 1620dc3
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/67aa54f4aa91a20008e97c55
😎 Deploy Preview https://deploy-preview-7710--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Feb 7, 2025

Pull Request Test Coverage Report for Build 13248936105

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 64.766%

Totals Coverage Status
Change from base Build 13213523731: 0.0%
Covered Lines: 5803
Relevant Lines: 8960

💛 - Coveralls

Copy link

@jcstanaway jcstanaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rschalo
rschalo previously approved these changes Feb 10, 2025
Copy link
Contributor

@rschalo rschalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmdeal jmdeal force-pushed the docs/do-not-disrupt-updates branch from 53e8c07 to 1620dc3 Compare February 10, 2025 19:35
Copy link
Contributor

@rschalo rschalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmdeal jmdeal merged commit 25aa6b2 into aws:main Feb 10, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Karpenter is terminating nodes that have pods with the do-not-disrupt annotation
4 participants