Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disruption budget drift replacement conflicting information #7480

Open
jhughes-mc opened this issue Dec 3, 2024 · 1 comment
Open

Disruption budget drift replacement conflicting information #7480

jhughes-mc opened this issue Dec 3, 2024 · 1 comment
Labels
documentation Improvements or additions to documentation

Comments

@jhughes-mc
Copy link

Description

The docs state:
Budgets will consider nodes that are actively being deleted for any reason, and will only block Karpenter from disrupting nodes voluntarily through drift, emptiness, and consolidation. Note that NodePool Disruption Budgets do not prevent Karpenter from cleaning up expired or drifted nodes.

The second sentence conflicts with the first regarding replacement of drifted nodes. Based on the ability to set a reason I believe this should be updated to reflect that budgets WILL blocks replacement for drifted nodes.
@jhughes-mc jhughes-mc added documentation Improvements or additions to documentation needs-triage Issues that need to be triaged labels Dec 3, 2024
@engedaam
Copy link
Contributor

engedaam commented Dec 10, 2024 •
edited
Loading

@jhughes-mc would be able to cut a PR for the docs fix?

@engedaam engedaam removed the needs-triage Issues that need to be triaged label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jhughes-mc @engedaam