fix(kernel): cannot pass decorated structs to kernel as "any" #997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The title of this Pull Request does not conform with [Conventional Commits] guidelines. It will need to be adjusted before the PR can be merged. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
When a struct is serialized with a $jsii.struct decoration from a jsii host language and passed into a value typed `any`, the kernel ignored the decoration. This resulted in a malformed object passed to the javascript code. This fix undecorates the object and continues to deserialize it as `any`. Fixes aws/aws-cdk#5066
eladb
force-pushed
the
rmuller/struct-tagging
branch
from
cee5b0b
to
684a368
Compare
eladb
changed the title
RomainMuller
commented
Nov 18, 2019
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
RomainMuller
commented
Nov 18, 2019
eladb
approved these changes
Nov 18, 2019
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
RomainMuller
added a commit
that referenced
this pull request
Nov 19, 2019
When moving out of callbacks, the result was not turned into a reference before being passed out to the jsii kernel, causing TypeErrors when attempting to turn structs (and probably other non-primitive types) to JSON. Discovered while attempting to reproduce #1003, which can no longer trigger as it depended on returning a Struct through and `any` and being hit with the bug fixed in #997... the fix also removed the conditions that make leveraging the cause possible (or at the very least I could not come up with a reproduction, and have verified that the original bug report no longer reproduces once #997 is in). That being said, still introduced the necessary changes to address the cause by properly discovering interfaces and adding the relevant overrides filtering, as this may improve the performance and reliability of the jsii runtime for Java. Fixes #1003
RomainMuller
added a commit
that referenced
this pull request
Nov 19, 2019
When moving out of callbacks, the result was not turned into a reference before being passed out to the jsii kernel, causing TypeErrors when attempting to turn structs (and probably other non-primitive types) to JSON. Discovered while attempting to reproduce #1003, which can no longer trigger as it depended on returning a Struct through and `any` and being hit with the bug fixed in #997... the fix also removed the conditions that make leveraging the cause possible (or at the very least I could not come up with a reproduction, and have verified that the original bug report no longer reproduces once #997 is in). That being said, still introduced the necessary changes to address the cause by properly discovering interfaces and adding the relevant overrides filtering, as this may improve the performance and reliability of the jsii runtime for Java. Fixes #1003
mergify bot
pushed a commit
that referenced
this pull request
Nov 28, 2019
* fix(python): correctly handle structs out of callbacks When moving out of callbacks, the result was not turned into a reference before being passed out to the jsii kernel, causing TypeErrors when attempting to turn structs (and probably other non-primitive types) to JSON. Discovered while attempting to reproduce #1003, which can no longer trigger as it depended on returning a Struct through and `any` and being hit with the bug fixed in #997... the fix also removed the conditions that make leveraging the cause possible (or at the very least I could not come up with a reproduction, and have verified that the original bug report no longer reproduces once #997 is in). That being said, still introduced the necessary changes to address the cause by properly discovering interfaces and adding the relevant overrides filtering, as this may improve the performance and reliability of the jsii runtime for Java. Fixes #1003 * improve documentation & test coverage * fixup * inline-fy doc * remove spurious 'final' * Add missing fget * add type annotation to make MyPy happy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a struct is serialized with a $jsii.struct decoration from a jsii host language and passed into a value typed
any, the kernel ignored the decoration. This resulted in a malformed object passed to the javascript code.This fix undecorates the object and continues to deserialize it as
any.Fixes aws/aws-cdk#5066
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.