fix(pacmak): fix a couple of issues related to java generation #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion Generating the aggregate POM could result in building a cyclic POM module tree, as the aggregate POM file would then be replacing the module's own POM. This stops aggregate-packaging single modules. Also addresses an issue with the builder method names being generated inconsistently across the Struct & Class builders, resulting in invalid call forwaring being attempted.
RomainMuller
changed the title
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
skinny85
approved these changes
Oct 30, 2019
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generating the aggregate POM could result in building a cyclic POM module tree,
as the aggregate POM file would then be replacing the module's own POM. This
stops aggregate-packaging single modules.
Also addresses an issue with the builder method names being generated
inconsistently across the Struct & Class builders, resulting in invalid
call forwarding being attempted.
Finally, it correctly generates overloads for Class builder methods.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.