feat(java): detect & rename members named after reserved words #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ds found in properties and method names to avoid compiler errors
| } | ||
|
|
||
| if (JavaGenerator.RESERVED_KEYWORDS.includes(propertyName)) { | ||
| return `${propertyName}Value`; |
There was a problem hiding this comment.
Might be worth checking whether this is the name of an existing property on the same type... If that is so, just bail out saying you're out of options there...
There was a problem hiding this comment.
Difficult to do, so in the interests of unblocking CDK builds moving ahead without this functionality for now.
| } | ||
|
|
||
| if (JavaGenerator.RESERVED_KEYWORDS.includes(methodName)) { | ||
| return `do${toPascalCase(methodName)}`; |
There was a problem hiding this comment.
Same as above, would be nice to have a collision check.
There was a problem hiding this comment.
Difficult to do, so in the interests of unblocking CDK builds moving ahead without this functionality for now.
…s a property called 'result'. Minor typo in comment fixed.
|
Looks good - just waiting for a confirmation build of the CDK to succeed before I approve this... To be safe... |
RomainMuller
changed the title
RomainMuller
approved these changes
Aug 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.