-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(java): overhauled structs with native implementation, builders, ... #694
Conversation
…s, equals and hashcode and creation from JSII. Additionally fixed a bug with diamond inheritance having duplicate properties
Pull request has been modified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other questions/thoughts:
Would be nice if there was imports and no fqcn
Can we get toBuilder() methods?
packages/jsii-java-runtime/project/src/main/java/software/amazon/jsii/JsiiObject.java
Outdated
Show resolved
Hide resolved
....jsii-calc-base/java/src/main/java/software/amazon/jsii/tests/calculator/base/BaseProps.java
Show resolved
Hide resolved
...sii-calc-lib/java/src/main/java/software/amazon/jsii/tests/calculator/lib/MyFirstStruct.java
Show resolved
Hide resolved
...a/src/main/java/software/amazon/jsii/tests/calculator/DiamondInheritanceBaseLevelStruct.java
Show resolved
Hide resolved
...lc/java/src/main/java/software/amazon/jsii/tests/calculator/DoNotRecognizeAnyAsOptional.java
Show resolved
Hide resolved
...cted.jsii-calc/java/src/main/java/software/amazon/jsii/tests/calculator/IJSII417Derived.java
Show resolved
Hide resolved
@bmaizels I've suspended the auto-merging of this PR so you can go through @spfink's suggestions and decide what you do with them... For some, maybe what you want to do is create an issue to look into that later (some of the comments are very much related to cosmetic improvements to generated code, which is good, but probably doesn't need to block this PR). Feel free to remove the |
Pull Request Checklist
|
Overhauled structs with native implementation, builders,
equals
andhashCode
and creation from JSII.Fixes #525
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.