Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(java): Escale */ in package-info.java #526

Merged
merged 2 commits into from
Jun 7, 2019
Merged

Conversation

RomainMuller
Copy link
Contributor

Code examples in the README.md file can contain multi-line comments
that will interfere with the comment block in package-info.java.
Escaping the */ to *{@literal /} fixes that issue.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Code examples in the `README.md` file can contain multi-line comments
that will interfere with the comment block in `package-info.java`.
Escaping the `*/` to `*{@literal /}` fixes that issue.
@RomainMuller RomainMuller requested review from costleya and a team as code owners June 7, 2019 14:59
@rix0rrr
Copy link
Contributor

rix0rrr commented Jun 7, 2019

jsii-pacmak:  diff-test for pacmak generator jsii-calc failed 
jsii-pacmak: ------------------------------------------------------------------------ 
jsii-pacmak:  To update expectation run: 
jsii-pacmak:     rsync -av --delete /tmp/tmp.v3Sy0g3U79/17135/29981/ /codebuild/output/src400129057/src/github.com/awslabs/jsii/packages/jsii-pacmak/test/expected.jsii-calc/ 
jsii-pacmak:  Or, execute this test again with: 
jsii-pacmak:     UPDATE_DIFF=1 
jsii-pacmak: ---------------------------

@rix0rrr rix0rrr merged commit 4e7ea98 into master Jun 7, 2019
@rix0rrr rix0rrr deleted the rmuller/escape-star-slash branch June 7, 2019 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants