fix(python): support variadic arguments #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eladb
suggested changes
Jun 3, 2019
| @@ -472,7 +472,13 @@ abstract class BaseMethod implements PythonBase { | |||
| paramNames.push(toPythonParameterName(param.name)); | |||
| } | |||
There was a problem hiding this comment.
Wouldn't it make more sense to simply check if param.variadic is true here and push a different value to paramNames?
There was a problem hiding this comment.
Yeah. I started with a change proposed in the original issue. Meant to clean it up but forgot. Testing my updates now.
There was a problem hiding this comment.
What I meant is that you can just add this condition when paramNames is being created in the first place (line 471):
for (const param of this.parameters) {
paramNames.push((param.variadic ? '*' : '') + toPythonParameterName(param.name));
}
eladb
approved these changes
Jun 3, 2019
garnaat
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #483
Handles variadic args and adds a test of VariadicMethod to the compliance tests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.