Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jsii-config): update jsii-config and docs with latest settings #4515

Merged
merged 5 commits into from
May 20, 2024

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented May 16, 2024

Updates jsii-config and the website with the latest settings for user-provided TypeScript configs.

The update to jsii-config includes some other changes that have previously been missed, including support for go and fixing a the outdir configuration.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mrgrain mrgrain added the pr/do-not-merge This PR should not be merged at this time. label May 16, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label May 16, 2024
Copy link
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicky comments about wording. Do with them as you want

@mrgrain mrgrain removed the pr/do-not-merge This PR should not be merged at this time. label May 20, 2024
Copy link
Contributor

mergify bot commented May 20, 2024

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label May 20, 2024
Copy link
Contributor

mergify bot commented May 20, 2024

Merging (with squash)...

Copy link
Contributor

mergify bot commented May 20, 2024

Merging (with squash)...

@mergify mergify bot merged commit 6e00874 into main May 20, 2024
35 checks passed
@mergify mergify bot deleted the mrgrain/chore/user-provided-tsconfig branch May 20, 2024 09:03
@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants