fix: exit with non-zero exit code if there are compilation errors #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skinny85
reviewed
Apr 8, 2019
skinny85
approved these changes
Apr 8, 2019
eladb
pushed a commit
to aws/aws-cdk
that referenced
this pull request
Apr 8, 2019
Until aws/jsii#442 is released we must fail builds on compilation errors. This is a temporary workaround for this issue (if there is something in stdout we consider that a compilation error).
4 tasks
eladb
pushed a commit
to aws/aws-cdk
that referenced
this pull request
Apr 8, 2019
Until aws/jsii#442 is released we must fail builds on compilation errors. This is a temporary workaround for this issue (if there is something in stdout we consider that a compilation error).
eladb
pushed a commit
to aws/aws-cdk
that referenced
this pull request
Apr 8, 2019
Until aws/jsii#442 is released we must fail builds on compilation errors. This is a temporary workaround for this issue (if there is something in stdout we consider that a compilation error).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #383 we modified the compiler to continue jsii validation despite
compilation errors but did not propagate the fact that there were
compilation errors.
This resulted in "jsii" exiting with a 0 exit code even in case
of errors.
Fixes #441
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.