fix(java): type generation code-gen issues #3735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some collection validations were emitted twice, due to a bad merge conflict resolution. Additionally, in certain cases where overrides are being emitted for type unions, the type checking code made unnecessary assertions, some of which ending up being prohibited by the compiler.
RomainMuller
force-pushed
the
rmuller/fix-java-codegen
branch
from
26b9f61
to
e6ea1b6
Compare
comcalvi
approved these changes
Aug 30, 2022
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some collection validations were emitted twice, due to a bad merge
conflict resolution.
Additionally, in certain cases where overrides are being emitted for
type unions, the type checking code made unnecessary assertions, some of
which ending up being prohibited by the compiler.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.