fix(pacmak): missing python artifacts when using relative -o path #3518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the `-o`/`--outdir` option is passed to `jsii-pacmak` with a relative path, that path was not resolved up-front by the CLI, which resulted in the Python code-generator not outputting the wheel files in the expected directory: instead of being consistently treated as relative to the current working directory, the Python generator interpreted it relative to it's temporary working directory. This addresses the issue by resolving relative paths to absolute paths, using `process.cwd()` as the base directory, before passing the value down to the business logic. Fixes aws/aws-cdk#20041
RomainMuller
added
bug
MrArnoldPalmer
approved these changes
May 5, 2022
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
-o/--outdiroption is passed tojsii-pacmakwith arelative path, that path was not resolved up-front by the CLI, which
resulted in the Python code-generator not outputting the wheel files in
the expected directory: instead of being consistently treated as
relative to the current working directory, the Python generator
interpreted it relative to it's temporary working directory.
This addresses the issue by resolving relative paths to absolute paths,
using
process.cwd()as the base directory, before passing the valuedown to the business logic.
See aws/aws-cdk#20041
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.