fix(pacmak): greatly reduce go code-gen memory footprint #3362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The go code generator was previously holding multiple copies of the `RootModule` objects for dependencies (one for the generated package's own `RootModule`, and one for each submodule that uses a type from that dependency), including their entire type hierarchy, methods and properties. On large packages, especially with many submodules, this results in an extremely large resident set size. Pathological cases have required heaps as big as 6 GiB. De-duplicating the `RootModule` instances, and not retaining `GoTypeRef` instances (which are stateless, and cheap to construct), allows reducing those pathological modules to only occupy around 300 to 400 MiB worth of heap, which is a very significant improvement. The reduction of duplication also has significant performance benefits on affected code-bases. The go bindings generate significantly faster on top of needing significantly less memory.
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
|
Thank you so much 🚀 |
ansgarm
added a commit
to hashicorp/terraform-cdk
that referenced
this pull request
Feb 10, 2022
…ce for Go) jsii v1.53.0 includes aws/jsii#3362
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The go code generator was previously holding multiple copies of the
RootModuleobjects for dependencies (one for the generated package'sown
RootModule, and one for each submodule that uses a type from thatdependency), including their entire type hierarchy, methods and
properties.
On large packages, especially with many submodules, this results in an
extremely large resident set size. Pathological cases have required
heaps as big as 6 GiB.
De-duplicating the
RootModuleinstances, and not retainingGoTypeRefinstances (which are stateless, and cheap to construct), allows reducing
those pathological modules to only occupy around 300 to 400 MiB worth of
heap, which is a very significant improvement.
The reduction of duplication also has significant performance benefits
on affected code-bases. The go bindings generate significantly faster on
top of needing significantly less memory.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.