feat: JSII_AGENT #325
Merged
feat: JSII_AGENT #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Language runtimes now set JSII_AGENT to include the runtime version such as "DotNet/1.2.3.4" or "Java/1.8.44". Fixes #324
RomainMuller
approved these changes
Nov 29, 2018
eladb
pushed a commit
to aws/aws-cdk
that referenced
this pull request
Dec 5, 2018
Add the jsii runtime version to the library version reporting under "jsii-runtime". jsii runtime clients populate the JSII_AGENT environment variable with this information (see aws/jsii#325). If JSII_AGENT is not defined, we assume this is a node.js runtime and include the node.js version. Fixes #1258
eladb
pushed a commit
to aws/aws-cdk
that referenced
this pull request
Dec 5, 2018
Add the jsii runtime version to the library version reporting under "jsii-runtime". jsii runtime clients populate the JSII_AGENT environment variable with this information (see aws/jsii#325). If JSII_AGENT is not defined, we assume this is a node.js runtime and include the node.js version. Fixes #1258
9 tasks
eladb
pushed a commit
to aws/aws-cdk
that referenced
this pull request
Dec 5, 2018
Add the jsii runtime version to the library version reporting under "jsii-runtime". jsii runtime clients populate the JSII_AGENT environment variable with this information (see aws/jsii#325). If JSII_AGENT is not defined, we assume this is a node.js runtime and include the node.js version. Fixes #1258 Fixes awslabs/cdk-ops#127
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Language runtimes now set JSII_AGENT to include the runtime version
such as "DotNet/1.2.3.4" or "Java/1.8.44".
Fixes #324
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.