Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rosetta): infuse drops first assembly #3243

Merged
merged 1 commit into from
Dec 10, 2021
Merged

fix(rosetta): infuse drops first assembly #3243

merged 1 commit into from
Dec 10, 2021

Conversation

kaizencc
Copy link
Contributor

@kaizencc kaizencc commented Dec 9, 2021

As part of a refactor, rosetta infuse no longer utilizes a single tablet file in favor of tablets at the assembly level. However the infuse command still takes in a positional argument TABLET that goes unused. This means that the first argument sent into the command gets dropped.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kaizencc kaizencc requested a review from rix0rrr December 9, 2021 16:24
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 9, 2021
@kaizencc
Copy link
Contributor Author

kaizencc commented Dec 9, 2021

btw, it looks like yargs would not "eat" an option as the first positional argument.

rosetta:infuse --cache-from='blah' assembly1 assembly2

result is TABLET=assembly1.

@rix0rrr rix0rrr merged commit 29a6a84 into main Dec 10, 2021
@rix0rrr rix0rrr deleted the remove-tablet branch December 10, 2021 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants