fix(dotnet/runtime): Incorrect callback response format #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The response for a callback completion that resulted in an error should use the `err` field name and not the `error` field name as was initially done. Additionally, the program flow did not propagate all errors back to the `jsii-kernel`, causing false-pass on the compliance test suite, as expectations were incorrectly set up to expect `RuntimeException` instead of `JsiiException`. Fixes #285
rix0rrr
approved these changes
Oct 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The response for a callback completion that resulted in an error should use the
errfieldname and not the
errorfield name as was initially done. Additionally, the program flowdid not propagate all errors back to the
jsii-kernel, causing false-pass on the compliancetest suite, as expectations were incorrectly set up to expect
RuntimeExceptioninsteadof
JsiiException.Fixes #285