fix(python): pin mypy to the exact version #2476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's been a couple of times `mypy` breaks the pipeline by releasing new versions that are more strict or start checking things it used to silently ignored. In order to avoid this happening in the future (and putting us back in control), this pins the `mypy` version to the exact release (the last we successfully built with, in this case), and moves everything we install though `pip install` into `requirements-dev.txt` files so that @dependabot can help us stay up-to-date going forward. Fixes #2464
RomainMuller
commented
Jan 26, 2021
| @@ -5,7 +5,6 @@ updates: | |||
| directory: '/' | |||
| schedule: | |||
| interval: daily | |||
| open-pull-requests-limit: 10 | |||
There was a problem hiding this comment.
Removed those limits because they're no longer necessary (they're mostly useful when you "just enabled" dependant on a codebase with a lot of outdated dependencies). This would improve our ability to remain up-to-date...
eladb
approved these changes
Jan 26, 2021
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
mergify bot
pushed a commit
that referenced
this pull request
Jan 27, 2021
Updated the type annotations of the jsii runtime for Python so that the decorators carry appropriate type signatures. Additionally, enhanced the code generation for Python so that mypy errors that are difficult or impossible to address are ignored by the tool without requiring specific user configuration. Relates to #2464, #2476 --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been a couple of times
mypybreaks the pipeline by releasing newversions that are more strict or start checking things it used to
silently ignored.
In order to avoid this happening in the future (and putting us back in
control), this pins the
mypyversion to the exact release (the lastwe successfully built with, in this case), and moves everything we
install though
pip installintorequirements-dev.txtfiles so that@dependabot can help us stay up-to-date going forward.
Fixes #2464
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.