feat(pacmak): prerelease identifier support #2146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an NPM package built with `jsii` is tagged with a version that includes a prerelease identifier (e.g: `1.2.3-alpha.1`), automatically represent this as a pre-release version in generated packages, too. For most currently supported languages, this simply means forwarding the version untouched, however for Python, prerelease identifiers need to be mapped into one of the supported tokens in PyPI (`.dev#`, `.a#`, `.b#` or `.rc#`). Fixes #2114
RomainMuller
added
language/python
nija-at
reviewed
Oct 20, 2020
Co-authored-by: Niranjan Jayakar <nija@amazon.com>
…muller/auto-preversions
nija-at
reviewed
Oct 22, 2020
…t (who also replaces 'fs' for it's own needs)
nija-at
suggested changes
Oct 28, 2020
Comment on lines
+3
to
+4
| The configuration for `jsii` is recorded in the `package.json` file, which is the standard package manifest for NPM | ||
| packages. This document describes the constraints and extensions `jsii` adds to the [package.json schema]. |
There was a problem hiding this comment.
(for the future) prefer wholesale adjustments and refactors to be separate PRs, hence separate commits 😉
There was a problem hiding this comment.
Yeah this is auto-format-on-save... -_-
nija-at
approved these changes
Oct 28, 2020
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an NPM package built with
jsiiis tagged with a version thatincludes a prerelease identifier (e.g:
1.2.3-alpha.1), automaticallyrepresent this as a pre-release version in generated packages, too. For
most currently supported languages, this simply means forwarding the
version untouched, however for Python, prerelease identifiers need to
be mapped into one of the supported tokens in PyPI (
.dev#,.a#,.b#or.rc#).Fixes #2114
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.