Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(go): runtime api json invalid tags #2115

Merged
merged 4 commits into from
Oct 13, 2020
Merged

Conversation

MrArnoldPalmer
Copy link
Contributor

Fixes missing quotes around go runtime api struct field JSON tags. This
would cause keys to not decode as expected.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Fixes missing quotes around go runtime api struct field JSON tags. This
would cause keys to not decode as expected.
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 13, 2020
@mergify
Copy link
Contributor

mergify bot commented Oct 13, 2020

The title of this Pull Request does not conform with [Conventional Commits] guidelines. It will need to be adjusted before the PR can be merged.
[Conventional Commits]: https://www.conventionalcommits.org

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
  • Commit ID: e37cd8b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@MrArnoldPalmer MrArnoldPalmer merged commit a9d96db into master Oct 13, 2020
@MrArnoldPalmer MrArnoldPalmer deleted the fix/go-runtime-json-tags branch October 13, 2020 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants