Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pacmak): python pack fails when installing 'black' via pip #1782

Merged
merged 2 commits into from
Jul 10, 2020

Conversation

nija-at
Copy link
Contributor

@nija-at nija-at commented Jul 9, 2020

The failure is because of intermittent unavailability of black or one of
its packages from the PyPI index.

Instead, install back into the environment, i.e., superchain, and use
that.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@nija-at nija-at requested review from RomainMuller and a team July 9, 2020 13:32
@nija-at nija-at self-assigned this Jul 9, 2020
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 9, 2020
@nija-at nija-at force-pushed the nija-at/build-failure-black branch from b0c3d38 to 0d75233 Compare July 9, 2020 13:33
@eladb
Copy link
Contributor

eladb commented Jul 9, 2020

Feels a bit weird to include this in superchain, but I see the pragmatic reasoning.

@nija-at nija-at marked this pull request as draft July 9, 2020 16:57
The failure is because of intermittent unavailability of black or one of
its packages from the PyPI index.

Instead, install back into the environment, i.e., superchain. Fallback
to installing it once in the user's home directory.
@nija-at nija-at force-pushed the nija-at/build-failure-black branch from 0d75233 to 097a007 Compare July 9, 2020 16:58
@nija-at nija-at marked this pull request as ready for review July 10, 2020 09:48
@nija-at nija-at added the pr/do-not-merge This PR should not be merged at this time. label Jul 10, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
  • Commit ID: 557585d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@nija-at nija-at removed the pr/do-not-merge This PR should not be merged at this time. label Jul 10, 2020
@nija-at nija-at merged commit d83e004 into master Jul 10, 2020
@nija-at nija-at deleted the nija-at/build-failure-black branch July 10, 2020 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants