fix(rosetta): crashes on behavioral interfaces #1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Behavioral interfaces (`ISomething`) weren't translated at all, and used
to crash the Java translator. Add translations for them.
Make the `jsii-rosetta` command-line tool more robust against errors in
the translator: catch and report the error, instead of crashing.
Add support for shorthand property assignments in object literals
(`someFunction({ foo });`) for Java as well, which wasn't covered
by any test yet.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
eladb
reviewed
Jan 3, 2020
| failures.push({ | ||
| category: ts.DiagnosticCategory.Error, | ||
| code: 999, | ||
| messageText: `Error translating snippet: ${e}\n${block.completeSource}`, |
There was a problem hiding this comment.
Prefix with “Jsii-Rosetta” or something like this.
eladb
approved these changes
Jan 3, 2020
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Behavioral interfaces (
ISomething) weren't translated at all, and usedto crash the Java translator. Add translations for them.
Make the
jsii-rosettacommand-line tool more robust against errors inthe translator: catch and report the error, instead of crashing.
Add support for shorthand property assignments in object literals
(
someFunction({ foo });) for Java as well, which wasn't coveredby any test yet.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.