Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EKS] [request]: tag Kubernetes managed nodes with node-role.kubernetes.io/<node-group-name>=true #733

Closed
yann-soubeyrand opened this issue Feb 3, 2020 · 7 comments
Labels
EKS Amazon Elastic Kubernetes Service Proposed Community submitted issue

Comments

@yann-soubeyrand
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Tell us about your request

The Kubernetes managed nodes should be tagged with node-role.kubernetes.io/<node-group-name>=true which would make the node group name visible at a quick glance when doing kubectl get nodes and would allow to quickly identify the nodes.

Which service(s) is this request for?

EKS.

Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?

When one has many node groups in a cluster, it's really convenient to be able to quickly identify which node group a node is part of. The de facto standard node-role.kubernetes.io/=true tag allows for this to happen when listing nodes with kubectl.

Are you currently working around this issue?

No, since tags ending with kubernetes.io aren't allowed on managed node groups.

@yann-soubeyrand yann-soubeyrand added the Proposed Community submitted issue label Feb 3, 2020
@mikestef9 mikestef9 added the EKS Amazon Elastic Kubernetes Service label Feb 3, 2020
@rtripat
Copy link

rtripat commented Mar 2, 2020

Nodes created using an EKS Managed Nodegroup have label key: eks.amazonaws.com/nodegroup and label value: <node-group-name> which can be used to filter nodes. Example kubectl command for a nodegroup with name ng-4e4d73712

kubectl get nodes --selector=eks.amazonaws.com/nodegroup=ng-4e4d73712

@tabern
Copy link
Contributor

tabern commented Mar 2, 2020

Closing as this functionality exists.

@tabern tabern closed this as completed Mar 2, 2020
@yann-soubeyrand
Copy link
Author

@tabern I disagree with you: the label exists and can be used for filtering but what I was asking for, though, is that the on purpose node-role.kubernetes.io/<node-group-name>=true label be used so that we can see which node group a nodes belongs to at a glance in the roles column of kubectl get nodes. Would you mind reopening this feature request please?

@zodiac12k
Copy link

@yann-soubeyrand i agree with you

@mdiver
Copy link

mdiver commented Mar 13, 2020

@yann-soubeyrand i agree too

@hong-kisung
Copy link

@yann-soubeyrand i agree with you

@yann-soubeyrand
Copy link
Author

@tabern could you please consider reopening this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EKS Amazon Elastic Kubernetes Service Proposed Community submitted issue
Projects
None yet
Development

No branches or pull requests

7 participants